elm-community / graph

Functional Graph Library in Elm.

Home Page:http://package.elm-lang.org/packages/elm-community/graph/latest

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update to elm 0.18

jhrcek opened this issue · comments

Could you please update this for elm 0.18?

The dependencies imeckler/queue and evancz/focus will need to be updated first. I know that Evan has said that focus is a possible antipattern, so the fact that it is not updated is likely deliberate.

Yeah, I'm currently thinking about options for an upgrade.

I think I could just copy and paste imeckler/queue into an internal module, but doing the same for evancz/focus is pretty much pointless without also offering it as a separate package.

I find using foci for this library pretty elegant, as it cuts out some repetition in update tasks. Totally don't understand the argument about being an anti-pattern, seems like premature optimization. Also that's no reason to just discontinue a library, but whatever.

So, I think there are two options to move this forward: Get rid of all focus related stuff or fork evancz/focus. Any opinions?

If focuses are not crucial to the module or its public interface, I'm thinking it should be rewritten without them.