Unify code formatting in the Native module

Question

Unify code formatting in the Native module

w0rm opened this issue 8 years ago · comments

I'm not sure if there is a preferred way to format JavaScript, I am happy with any coding style but it has to be consistent.

Perhaps we can as well add an eslint config or something.

Nick Hollon · Answer 1 · Mon May 23 2016 02:11:28 GMT+0800 (China Standard Time)

I think this is a fine idea. Most of the original JS was written by @johnpmayer... maybe he has a suggested style?

The style I use personally is the strictest settings for JSHint, but it looks like the tool has changed a bit since the last time I used it.

Andrey Kuzmin · Answer 2 · Mon Jul 04 2016 04:27:35 GMT+0800 (China Standard Time)

I added an eslint config for the most recent version of eslint. The cool thing about it, is that you can run eslint src/Native --fix and it will fix the formatting itself.

It also discovered a bug in throw error('No info available for: ' + attribute.type); where error should be new Error