`fromISO8601` fails when date ends with `.000Z`

Question

`fromISO8601` fails when date ends with `.000Z`

witoldsz opened this issue 7 years ago · comments

1970-01-01T00:00:00.000Z (this is how dateObj.toISOString() works)
Err "Errors encountered at position 19: expected \"Z\" or expected an integer"
1970-01-01T00:00:00Z
Ok (DateTime { date = Date { year = 1970, month = 1, day = 1 }, offset = 0 })

See: https://runelm.io/c/enq

Workaround:

DateTime.fromISO8601 <| Regex.replace Regex.All (regex "[.]000Z") (\_ -> "Z") str

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString

Scott Smith · Answer 1 · Tue Feb 21 2017 14:41:41 GMT+0800 (China Standard Time)

@witoldsz Nice! Would you like to submit a pull request? If you've never submitted one, I can walk you thru it.

Witold Szczerba · Answer 2 · Tue Feb 21 2017 19:48:45 GMT+0800 (China Standard Time)

I don't get the idea of elm-combine yet. Will try to figure it out and then I could prepare the fix :) You know, years and years of OOP, I hope my brain is not damaged and I can still recover, heh

Witold Szczerba · Answer 3 · Tue Feb 21 2017 22:29:01 GMT+0800 (China Standard Time)

So this is how far I've get:

[ ~/projects ]$ git clone https://github.com/elm-community/elm-time.git
[ ~/projects ]$ cd elm-time
[ ~/projects/elm-time {master} ]$ elm-test
Starting downloads...

  ● elm-community/lazy-list 1.0.0
  ● elm-community/json-extra 2.1.0
  ● Bogdanp/elm-combine 3.1.1
  ● elm-community/elm-test 3.1.0
  ● elm-community/shrink 2.0.0
  ● elm-lang/lazy 2.0.0
  ● mgold/elm-random-pcg 4.0.2
  ● elm-lang/core 5.1.1
  
● rtfeldman/node-test-runner 3.0.0
Packages configured successfully!
Success! Compiled 61 modules.                                       
Successfully generated /tmp/elm_test_117121-7494-b5ir48.dx49ara4i.js
The test run failed because it encountered a runtime exception:

 RangeError: Maximum call stack size exceeded
    at /opt/node/lib/node_modules/elm-test/bin/elm-test:119:37
    at evalElmCode (/opt/node/lib/node_modules/elm-test/bin/elm-test:119:76)
    at /opt/node/lib/node_modules/elm-test/bin/elm-test:303:33
    at process._tickCallback (internal/process/next_tick.js:103:7)

[ ~/projects ]$ node --version
v7.4.0
[ ~/projects ]$ elm --version
0.18.0

I think I have seen this bug somewhere #13…

Scott Smith · Answer 4 · Thu Feb 23 2017 10:34:24 GMT+0800 (China Standard Time)

Did you attempt to run the test w/ your fix included? I'll try the test myself.

…

On Tue, Feb 21, 2017 at 6:29 AM, Witold Szczerba ***@***.***> wrote: So this is how far I've get: [ ~/projects ]$ git clone https://github.com/elm-community/elm-time.git [ ~/projects ]$ cd elm-time [ ~/projects/elm-time {master} ]$ elm-test Starting downloads... ● elm-community/lazy-list 1.0.0 ● elm-community/json-extra 2.1.0 ● Bogdanp/elm-combine 3.1.1 ● elm-community/elm-test 3.1.0 ● elm-community/shrink 2.0.0 ● elm-lang/lazy 2.0.0 ● mgold/elm-random-pcg 4.0.2 ● elm-lang/core 5.1.1 ● rtfeldman/node-test-runner 3.0.0 Packages configured successfully! Success! Compiled 61 modules. Successfully generated /tmp/elm_test_117121-7494-b5ir48.dx49ara4i.js The test run failed because it encountered a runtime exception: RangeError: Maximum call stack size exceeded at /opt/node/lib/node_modules/elm-test/bin/elm-test:119:37 at evalElmCode (/opt/node/lib/node_modules/elm-test/bin/elm-test:119:76) at /opt/node/lib/node_modules/elm-test/bin/elm-test:303:33 at process._tickCallback (internal/process/next_tick.js:103:7) I think I have seen this bug somewhere #13 <#13>… — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAET9N-FOWZGTNJHf82ezLGDcpPaKMfSks5revSugaJpZM4ME8cO> .

-- Scott Smith http://twitter.com/_ofd (OldFartDeveloper)

Witold Szczerba · Answer 5 · Fri Feb 24 2017 02:46:38 GMT+0800 (China Standard Time)

No, all I did was the commands I've pasted. Haven't had time since then to further look into it.
:-(

Witold Szczerba · Answer 6 · Sat Feb 25 2017 06:40:52 GMT+0800 (China Standard Time)

OK, so I tried to figure out what's causing the troubles. I have discovered that the root cause of all this RangeError: Maximum call stack size exceeded is how Elm translates the List's […] into JavaScript. The longer the list is, the deeper the stack. With few hundreds elements it crashes.

I will file a bug and try to figure out a workaround.

Witold Szczerba · Answer 7 · Sat Feb 25 2017 08:02:27 GMT+0800 (China Standard Time)

~~List literal with many items leads to "Maximum call stack size exceeded"~~
~~elm-lang/core#840~~
"Maximum call stack size exceeded" with large List #1521
elm/compiler/issues/1521

Scott Smith · Answer 8 · Wed Mar 01 2017 13:15:35 GMT+0800 (China Standard Time)

Merged #23 to I'm closing this issue. @witoldsz, thanks for the PR; it was perfect

Scott Smith · Answer 9 · Thu Mar 02 2017 14:16:24 GMT+0800 (China Standard Time)

Version in elm-community has been bumped to 1.0.2