ellisonleao / gruvbox.nvim

Lua port of the most famous vim colorscheme

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Diffs in neogit not as expected

tilupe opened this issue · comments

Describe the bug
Since a while the background colors of a git diff in neogit cover the whole diff.
Therefore the text is either not visible at all or just barely.
Problem only occurred since a while, unfortunately I can't remember since when,
so I don't know if it was a gruvbox update or a neogit update.

To Reproduce
Steps to reproduce the behavior:
Install neogit and see a diff of a modified file.
Keep/Set "inverse" to true
I tried my config with custom setting and without and I deleted the whole plugin
several times.

Expected behavior
Diff colors are at least like in the diffview.nvim view or even better as in
#225
(I don't know why this commit was reverted...)

Screenshots
Neogit diff view when cursor is off the modified file
image

Neogit diff view when cursor is on deleted part
image

Neogit diff view when cursor is on the file name
image

Neogit diff view with inverse false
image

Same file viewed in diffview.nvim
image

Additional context
Add any other context about the problem here.

hey @TimothyPescatore unfortunately i don't have too much time to work on this right now but there's a discussion ongoing about diffs here. Since neovim introduced semantic highlights in the newer versions, we will need to check what's the best way to handle this issue

moving this to the discussion