elkowar / eww

ElKowars wacky widgets

Home Page:https://elkowar.github.io/eww

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] jq broken in 5.0.0

kthu opened this issue · comments

Checklist before submitting an issue

  • I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
  • I have specifically verified that this bug is not a common user error
  • I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug

After upgrading to eww 5.0.0 all my jq expressions are broken. It seems they always return the full document regardless of the filter.

Here is a simple example:

❯ eww --version
eww 0.5.0 387d344690903949121040f8a892f946e323c472
❯ bat ~/.config/eww/eww.yuck
   1   (defvar ws {jq("[7,8,9]", ".[0]")})
   2   
❯ eww reload
❯ eww get ws
[7,8,9]
❯ eww get ws | jaq ".[0]"
7

Reproducing the issue

No response

Expected behaviour

No response

Additional context

No response

For an easy bisect it would be nice to know which version/commit you were previously on, would you mind adding that?

Yeah, sorry about the bad bug report.

I'm not sure exactly which version I was on before upgrading since it was built from git, but it was 0.4.0 something.

I've now tested various revisions, and 4385782 is the culprit. e6817f2 works fine.

Version in nix unstable has the same bug

Version in nix unstable has the same bug

This is due to nixpkgs currently using the v0.5.0 tag, as can be seen here.

Version in nix unstable has the same bug

This is due to nixpkgs currently using the v0.5.0 tag, as can be seen here.

Sorry if I'm missing something, isn't v0.5.0 the latest release?

@cmargiotta it is.
@cmargiotta @kthu I'd appreciate it if you could test my pr branch and see whether that fixes jq for you.

Yes, that fixed it! 👍

Yes, it works correctly now! Thank you so much!