The whole page should be localized
gemantzu opened this issue · comments
Right now, when you click on a translation on the top right, nothing changes besides the lessons' content itself.
What should change:
- lessons content
- lessons links in navbar
- starting page for each language should show up instead of always English
- navbar itself
@gemantzu have you checked the code itself to see if it has gettext setup? We may just need to generate the localses?
no, doing so right now. The translation landing page though and the navbar localized lessons should not be gettext specific, I think it's code specific
Hm, I see that the navbar lesson titles are coming from gettext, AND the setup for the english version is there. Are we good with this option, or do you think we should rely on the lessons themselves to provide these titles?
I noticed it also! Its a minor thing since all lessons are translated but cause a bad impression for people who won't understand english since looks like the localization won't work in first glance.
I'm from Brazil, most people I recommend the content in elixir school won't know english would be nice have the main page and menus in Portuguese.
#192 should do the trick!
All that's needed now for all languages, is to have each .po file in here translated accordingly.
Closing out this issue since it was added in #192, feel free to re-open or create a new issue if there is more work, but since we have the ground work laid for full-page translations I think we can close it safely.