elixir-image / image

Image processing for Elixir

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

evision dependency isn't optional?

martosaur opened this issue · comments

If I add {:image, "0.9.0"} to an app it won't start with ** (Mix) Could not start application evision: could not find application file: evision.app error. This isn't the case for 0.8.0

@martosaur Thanks for the report and sorry for the inconvenience. I have published image 0.10.0 which I believe fixes this issue. You may have to rm -rf _build to ensure a clean environment. The changelog entry is:

Bug Fixes

  • Since the mix build process does a File.cwd!/1 to the directory of each dependency we can't use the dirname of the dependency to decide whether to configure :evision or not. The strategy is now changed to configure :evision only if the environment CONFIGURE_EVISION is set. Note this is only relevant when developing :image itself. Consumers of the library should add :evision as a dependency manually in their application mix.exs as described in the readme. Thanks to @martosaur for the report. Closes #13.
commented

Hi @kipcole9, sorry to jump into the conversation here, just to add something from my side :)

I'd like to publish :evision on hex.pm soon (maybe this weekend or by the end of next week). The main reason I haven't done so is that :evision is likely to have a little bit more breaking changes in the following days/weeks. However, it seems that it's perhaps about time to have some early releases on hex.pm (so that it would be easier for other libraries, like this one, to use it as a dependency).

I plan to do that starting from v0.1.7, and it will prefer to use precompiled binaries (if available) by default.

@cocoa-xu, that would be great from my point of view. Image is primarily about a more idiomatic and approachable set of functions for common imaging requirements that either Vix/libvips or eVision/OpenCV can provide. Therefore I am completely comfortable with breaking changes - its my responsibility to keep the public API of Image consistent even if the libraries underneath change.