Giters

eliotsykes / asset_fingerprint

Asset Fingerprint Plugin for Ruby on Rails - allows you to use md5 or timestamps in query string or in asset filenames as suggested by Google Page Speed

Home Page:http://github.com/eliotsykes/asset_fingerprint

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Is this Rails 3 Friendly?

bhellman1 opened this issue · comments

commented

Just tried to install and got hit with an error:

$ rails plugin install https://github.com/eliotsykes/asset_fingerprint.git
/Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/railties-3.0.5/lib/rails/commands/plugin.rb:277:in <top (required)>': Commands is not a module (TypeError) from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/activesupport-3.0.5/lib/active_support/dependencies.rb:239:inrequire'
from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/activesupport-3.0.5/lib/active_support/dependencies.rb:239:in block in require' from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/activesupport-3.0.5/lib/active_support/dependencies.rb:225:inblock in load_dependency'
from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/activesupport-3.0.5/lib/active_support/dependencies.rb:596:in new_constants_in' from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/activesupport-3.0.5/lib/active_support/dependencies.rb:225:inload_dependency'
from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/activesupport-3.0.5/lib/active_support/dependencies.rb:239:in require' from /Users/bhellman/.rvm/gems/ruby-1.9.2-p180@andyw/gems/railties-3.0.5/lib/rails/commands.rb:17:in<top (required)>'
from script/rails:6:in require' from script/rails:6:in

'

commented

Asset fingerprint has not been made rails 3 friendly yet. If you feel up to the job please go ahead.

commented

We have been using asset_fingerprint for the past year and it was awesome - did exactly what we need. We recently updated to Rails 3 and this broke for us, too. I ended up finding https://github.com/polleverywhere/asset_fingerprinter to fit the needs for us (which is inspired from this plugin).

I thought about tackling making it Rails 3 friendly, but with the asset pipeline stuff, do you think it would be worth the energy?

commented

Thanks Nate, I wish I would have found that a few days ago. I agree, it's not at all worth tackling with the asset pipeline near release. We're looking for something to hold us over until Heroku supports Rails 3.1.

commented

Added links to Rails 3 and Rails 3.1 asset fingerprint solutions to this plugin's readme: 3ec68b2