is dwarf_decode_address.py suite for dwarf version 5 ?

Question

is dwarf_decode_address.py suite for dwarf version 5 ?

DogeWatch opened this issue a year ago · comments

https://github.com/eliben/pyelftools/blob/master/examples/dwarf_decode_address.py#L91
I found filename = lineprog['file_entry'][prevstate.file - 1].name should change to filename = lineprog['file_entry'][prevstate.file].name to parse the dwarf version 5 file.

Seva Alekseyev (he/him) · Answer 1 · Thu Mar 16 2023 00:46:32 GMT+0800 (China Standard Time)

That is true. The rule that index zero means default file was deprecated in DWARF 5. That said, the line should not go like that either; it should be conditional on the DWARF version; we don't want to kill backward compatibility, either.

Eli Bendersky · Answer 2 · Wed Mar 22 2023 21:32:03 GMT+0800 (China Standard Time)

Is this fixed by #463 and should be closed?

Eli Bendersky · Answer 3 · Sat Mar 25 2023 23:42:12 GMT+0800 (China Standard Time)

Closing. Reopen if needed, explaining why #463 is not a fix