elemental-lf / benji

Benji Backup: A block based deduplicating backup software for Ceph RBD images, iSCSI targets, image files and block devices

Home Page:https://benji-backup.me

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

helpers/ceph.py requires pool is 'rbd'

jsm222 opened this issue · comments

Using benji.helpers.ceph.backup your pool must be called rbd
since the scheme is the pool name

benji_args.extend([f'{pool}:{pool}/{image}@{snapshot}', volume])

benji_args.extend([f'{pool}:{pool}/{image}@{snapshot}', volume])

.

my local fix is to hardcode 'rbd' as scheme

Hmm, you can rename your instance of the RBD i/o module in your benji.conf to match your pool name. Note that this is just a convention that ceph.py uses, the scheme doesn't have to match the pool name. It can be helpful in the case where different credentials or configurations are needed for different pools but it has its limitations when multiple clusters with overlapping pool names are involved.

@jsm222 do you still see a problem here after my clarification?

Oh I see, I thought of the "rbd" as a scheme it is of course the name of the module,which knows that it is of type rbd. So no problem, thanks for clarifying.