Reply-quotes of code blocks have unsymmetrical padding
HarHarLinks opened this issue · comments
Steps to reproduce
- reply to a message with code block
Outcome
What did you expect?
text is vertically centered
What happened instead?
- code block has less padding overall (while different, this is reasonable. in fact it would be reasonable everywhere imo)
- code block has no numbers
- code is not vertically centered in block
- (replies quoting code blocks can quote >2 lines, not sure if that's intentional)
Operating system
arch
Application version
Element version: 1.10.10 Olm version: 3.2.8
How did you install the app?
aur
Homeserver
1.56
Will you send logs?
No
- code block has no numbers
- code is not vertically centered in block
I think these are not really intentional and should be addressed. Not sure about the padding width.
What is the expected ui for this? Is there any A/C to be met?
May be I can help with resolving the issue.
@allenabraham777 I'd say the smaller top margin should be replicated to the bottom, but ideally this is done in such a way where it becomes a single PCSS variable which applies to the margin consistently so it can be easily tweaked.
What about the "lines of quote" (hehehe)?
#10084 Opened pull request with the fix for the issue
the issue to be fixed vertical text alignment and padding issues in top and bottom
before the fix:
after the fix:
and for the only 2 lines of code showing up in reply I think it is intentionally set up by the developers
@HarHarLinks please let me know if that is the issue you were mentioning about
Thank you for working on this.
code block has less padding overall (while different, this is reasonable. in fact it would be reasonable everywhere imo)
accepted as OK by t3chguy
code block has no numbers
not resolved:
code is not vertically centered in block
looks good to me:
(replies quoting code blocks can quote >2 lines, not sure if that's intentional
your test case is incorrect. on nightly 2023020501 this is still the current behaviour:
replies quoting code blocks can quote >2 lines, not sure if that's intentional
@HarHarLinks I am not sure if I am understanding wrong but I think the developers intentionally added this where they only show 2 lines of text in the reply if a code block comes after 2 lines then it is not shown but if code block comes in 1st or 2nd line then in total 2 lines of code block and 2 lines of text is shown (ie. 4 lines max) in other cases code block is hidden ... so most probably it is intentional ..... but again I might be misunderstanding and be wrong sorry in advance if that's the case
@t3chguy can you please clear up the confusion
adding some test pics of my testing
That seems incredibly inconsistent to me. Maintainers or UX team will have to confirm the intended way.
To be clear: I think it is supposed to show 2 lines total max, not (for example) 2 lines of text and 2 lines of code block.
What is the latest on this one? I can work on this.
- What are the intended number of lines?
- Do we need to show line numbers in code-block replies?