elemaudio / elementary

Elementary is a JavaScript library for digital audio signal processing.

Home Page:https://www.elementary.audio/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TypeScript type definitions for core events

satelllte opened this issue Β· comments

Hi πŸ‘‹πŸ»
First of all, I want to say thank you for creating Elementary Audio and bringing it to open source. It's pleasure to work with it ❀️

I'm happy that the library is mostly typed in TypeScript, but there's the gap in core events. So when I'm using core.on() it doesn't suggest me the enum of available events as well as the callback event type, so right now it's just:

core.on(eventName: string | symbol, listener: (...args: any[]) => void)

Is it possible to provide type definitions for it? πŸ™πŸ»

Hey, thank you! ❀️

Yes, absolutely, that suggestion is one I've received before and I just haven't gotten to it yet. I'll make sure this change is part of a series of improvements for the types layer

Resolved in #23 by @bgins πŸ™Œ