elegantapp / pwa-asset-generator

Automates PWA asset generation and image declaration. Automatically generates icon and splash screen images, favicons and mstile images. Updates manifest.json and index.html files with the generated images according to Web App Manifest specs and Apple Human Interface guidelines.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

--single-quotes doesn't work as expected

caseywebdev opened this issue · comments

I tried to use --single-quotes and noticed it made no difference in the output. Dug through the code and it looks like this line doesn't actually do anything because .replace doesn't mutate the original string.

https://github.com/onderceylan/pwa-asset-generator/blob/a444f76b937d17e621bb5bb22b6352ea3d4fa9f2/src/helpers/meta.ts#L180

The line would need to be more like

htmlMeta[metaKey] = metaContent.replaceAll('"', "'");