Giters

elegantapp / pwa-asset-generator

Automates PWA asset generation and image declaration. Automatically generates icon and splash screen images, favicons and mstile images. Updates manifest.json and index.html files with the generated images according to Web App Manifest specs and Apple Human Interface guidelines.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Support for custom browser path

max-programming opened this issue · comments

commented

Is your feature request related to a problem? Please describe.
Just discovered it's an amazing package that lets us generate assets for a PWA. But as it uses puppeteer-core, it's better if we don't find Chrome on a user's system, they can enter the path of the Chromium-based browser they might be using.

For eg. Microsoft Edge, Brave, Chrome (Beta, Dev or Canary version)

Describe the solution you'd like
Adding a flag to take the path input or a prompt asking "Enter the path of your Chrome or Chromium-based browser".

Additional context
As I had Microsoft Edge installed on my system, I thought it would maybe ask for the path or take the existing MS Edge path from env variables If the user is on Windows. But it didn't and as I didn't have Chrome installed, it was downloading Chromium.