Not Found for existing repository
MarshallOfSound opened this issue · comments
Gave this a shot with one of my repos.
Throws a Not Found 🤔 Not sure what's going on there
We updated the URL scheme a bit and landed some fixes (for example, asset detection was off):
$ curl curl https://electron-update-server.herokuapp.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/darwin/4.0.0 | json_pp
{
"url" : "https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/releases/download/v4.5.0/Google.Play.Music.Desktop.Player.OSX.zip",
"notes" : "This is a minor release of Google Play Music Desktop Player\r\n\r\nHere is a quick run down of all things that have changed.\r\n<ul style=\"padding-left: 20px\">\r\n <li style=\"list-style-type: disc\">NEW: Added ListenBrainz support</li>\r\n <li style=\"list-style-type: disc\">NEW: Discord Rich Presence Integration</li>\r\n <li style=\"list-style-type: disc\">NEW: Support for Google Cast Groups (finally)</li>\r\n <li style=\"list-style-type: disc\">NEW: If lyrics can't be automatically found there's now a handy button to search for them on Google</li>\r\n <li style=\"list-style-type: disc\">NEW: You can now disable disabling hardware acceleration on macOS (kinda enabling I guess)</li>\r\n <li style=\"list-style-type: disc\">NEW: For all you hungarians, we now have hungarian language support</li>\r\n <li style=\"list-style-type: disc\">NEW: Global hotkey for \"I'm feeling lucky\"</li>\r\n <li style=\"list-style-type: disc\">NEW: Clicking on the volume icons now updates the volume (makes sense right?)</li>\r\n <li style=\"list-style-type: disc\">FIX: JSON and Playback API time fields now don't climb to infinity and beyond</li>\r\n <li style=\"list-style-type: disc\">FIX: You can now type in an input box and pause your music at the same time, crazy stuff...</li>\r\n <li style=\"list-style-type: disc\">FIX: If you're in fullscreen mode and you quit, you won't be left staring into the void</li>\r\n <li style=\"list-style-type: disc\">FIX: If for whatever reason you have more than 12 chromecasts you can now scroll the cast device list</li>\r\n <li style=\"list-style-type: disc\">FIX: There is now an easy way to remove hotkeys</li>\r\n</ul>\r\n\r\nThanks to all the people who have helped with these features and fixes.<br />\r\n",
"name" : "Version 4.5.0"
}$ curl -I https://electron-update-server.herokuapp.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/darwin/4.5.0
HTTP/1.1 204 No Contentbtw, hazel wouldn't have picked up the OSX.zip asset either
Looks like this is working now:
$ curl "https://update.electronjs.org/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/darwin/4.5.0"
2018-04-20T19:16:07.558531+00:00 app[web.1]: cache hit MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/darwin
2018-04-20T19:16:07.559147+00:00 app[web.1]: up to date
2018-04-20T19:16:07.559435+00:00 app[web.1]: GET /MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/darwin/4.5.0 204
It would be helpful if these 204 responses also had a body like "Success: 4.5.0s is the latest version". Is that allowable or does autoUpdater expect an empty response body?
204 specifically means No Content, see https://httpstatuses.com/204. I guess we can close this now?
We could add a header, like X-UPDATE: 4.5.0 is the latest version? This would only be visible to people inspecting the headers though.