electron-userland / electron-installer-dmg

Create DMG installers for your electron apps using appdmg.

Home Page:https://github.com/electron-userland/electron-installer-dmg

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add a TypeScript definition

mahnunchik opened this issue · comments

It wold be nice to add a TypeScript definition.

Related: electron/forge#1755

See electron-userland/electron-installer-snap#72 for an example of how to do it.

I created a PR on DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#54338

I would actually prefer an in-package definition type rather than a separate one.

What do you think about rewriting this in TypeScript? It's not that much work.

I opened a PR for the definitions @malept :)

What do you think about rewriting this in TypeScript? It's not that much work.

I would be hesitant to convert this to TypeScript mostly because I need to see how comprehensive the testsuite is first.