electrodejs / deprecated-electrode-archetype-react-app

A WalmartLabs flavored React Universal App archetype

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Move babel configuration to `babel-preset-electrode-react`

wmertens opened this issue · comments

That way it's easier to configure .babelrc in projects, presets: ["electrode-react"] instead of depending on the full path to the file in this module.

I took a stab at this:

I verified it by following the Getting Started guide but replacing the .babelrc file with the JSON below. The code for the app is available here.

{
  "presets": ["electrode-react"]
}

I wasn't sure of the contribution process with electrode but wanted to give this a shot and give back. If there's anything else I can provide to assist on this issue please let me know. Thank you all for the great work!

thanks much @codiemullins for quickly jumping and coming up with a solve.
thanks @wmertens for suggesting this enhancement, makes the project/.babelrc file much more cleaner.

we will make sure to add babel-preset-electrode-react in electrode repos.

@codiemullins could you give me owner permission to the module please? would you mind PR the repo into the new lerna repo as a packages as well please? https://github.com/electrode-io/electrode/tree/master/packages

issue's been moved to the new repo electrode-io/electrode#564