electricui / electricui-embedded

Add communications functionality to connect your hardware to a local user interface.

Home Page:https://electricui.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Review ingest_response_packet_query tests for correctness

Scottapotamas opened this issue · comments

During the large refactor of error handling etc, the test_ingest_response_packet_query in test_electricui_packet_parse.c failed to pass after expected modifications were made.

The confusion regards the incorrect test fixtures (copy paste errors?), and invalid comments relating to the intended mutability of the variable being queried against.

The test was intented to test the query + no_write functionality, but was actually writing.