electerious / basicLightbox

The lightest lightbox ever made.

Home Page:https://basiclightbox.electerious.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Handling <picture> tag

8lall0 opened this issue · comments

When i try to put a tag, since i want to support webP, the image acts weird.

Can you provide a reproducible demo or a detailed explanation of what you're doing and what's happening?

Since the tag is not handled, if an image is bigger than the viewport it simply covers all.I took a look at your code, you only take care of direct children (>img, >iframe etc.) and, since it's not handled, it doesn't append the correct modifier class (--img etc.).

Maybe i found a way, do you accept pull requests?

Maybe i found a way, do you accept pull requests?

Sure!

Done :) i close this issue!