elastic / package-storage

Package storage for packages served through the package registry service

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Proposal: Use [branch] in PRs as title prefix

ruflin opened this issue · comments

One thing that I think @ycombinator started is to use [branch-name] as a prefix in the PR title to describe what branch it targets. I personally find this very useful to quickly spot against what branch a PR should be and also if the same PR happens three times, differentiate between them.

So this is a proposal that we prefix our PR's with the according branch name like [snapshot].

Haha, I think this was not intentional on my part TBH. It is a result of using https://github.com/sqren/backport 😄

At any rate, I think it's a nice convention so I'm ++ to following it.

Sounds good to me!

SGTM!

Already adjusted the one active: #187

Seems like we are in agreement then. Will try to add it to our README as convention then.

Once the README is updated, I think we can close this issue.

Yep, good timing. I just opened #211