unlock/upgrade faraday dependency

Question

unlock/upgrade faraday dependency

kares opened this issue 2 years ago · comments

atm, both elasticsearch-transport (7.17.1) as well as the new elastic-transport (8.0.1) lock
the faraday gem to ~> 1

effectively meaning 1.x is always used on all versions of Ruby.

faraday 2.x requires 2.6 as minimum which might be hard to support unless required Ruby >= 2.6 for the gem.

NOTE: we do not need 2.x but thought this might be worth tracking to get a notification when Faraday is updated (we will have to adjust some test code)

Fernando Briano · Answer 1 · Mon May 30 2022 23:05:21 GMT+0800 (China Standard Time)

Hi @kares! Upgrading to Faraday 2.x is on the to-do list. It's going to be tracked for 8.x in elastic-transport. I think the main breaking change is with the adapters, but I'll look into it once I start that work. I'll try to keep backwards compatibility as much as possible and I'll ping you once there's any progress.

Karol Bucek · Answer 2 · Mon May 30 2022 23:13:37 GMT+0800 (China Standard Time)

Thanks Fernando, I see there's elastic/elastic-transport-ruby#21
So I am fine closing this one instead of the other issue ... which is closer to the source 😉

Fernando Briano · Answer 3 · Wed Sep 07 2022 18:14:52 GMT+0800 (China Standard Time)

@kares with elastic-transport-ruby 8.1.0, the Faraday dependency was unlocked and now Faraday 2 can be used. I tested a lot with elasticsearch-ruby and enterprise-search-ruby and it looks like everything is ok. Since elasticsearch depends on 'elastic-transport', '~> 8', it would be upgraded to 8.1.0 on update and Faraday 2 could be used. Let me know if you test this and if you have any issues. Thanks!