Update readme

Question

Update readme

cimtico opened this issue 10 years ago · comments

cimtico commented 10 years ago

Readme routing step says:

get "/delayed_job" => DelayedJobWeb, :anchor => false

but for all the interactions to work it should say:

match '/delayed_job' => DelayedJobWeb, :anchor => false, :via => :all

Andrew Atkinson · Answer 1 · Wed Jan 22 2014 01:58:01 GMT+0800 (China Standard Time)

Hi @cimtico. We just proposed this change to add a post route as well, would that solve your issue? I think match was deprecated in Rails 4. #43

I sent that PR but didn't get a chance to test it. If you're able to verify that a post route solves the issue, I can merge in the documentation change. Thanks!

cimtico · Answer 2 · Wed Jan 22 2014 03:00:08 GMT+0800 (China Standard Time)

Hi, and thanks for the quick reply.
My app is running on Rails 4 and match is still supported (but it requires the ":via => ..." setting to work correctly).
The post route would also work. I proposed the "match via all" so it would handle get and post to anything under the specified route. But adding the post manually should also work.

Andrew Atkinson · Answer 3 · Wed Jan 22 2014 12:39:43 GMT+0800 (China Standard Time)

@cimtico Thanks for pointing out the via part of the route. I think that is a better solution, so I changed the PR to set that for get and post. I was given commit rights so I merged that in here 4fcafee. Can I close the issue?

cimtico · Answer 4 · Thu Jan 23 2014 23:59:14 GMT+0800 (China Standard Time)

sure go ahead.
Thanks for the quick update 👍