UTF-8 charaters on Windows
msroth opened this issue · comments
Thanks for this script! I am running it on Windows and it seems to dump out when it hits some of the foreign characters in the description (?) column. Consequently, I am only able to download about 90 image files. Any way to make it decode those characters? Or this there another issue?
Hi @msroth thanks for the issue. I think this is due to csv dict reader. I'm going to push something now that should fix it.
Thank you. I’ll look for it.
Cheers,
Scott Roth
[Armedia_blue_small]
Test & Evaluation Lead
Science and Technology Integration Lab (STIL)
2070 Chain Bridge Dr., #100
Vienna, VA 22182
scott.roth@armedia.com
Cell: 703-408-1187
Office: 571-395-8875
From: Eddie Bell [mailto:notifications@github.com]
Sent: Thursday, October 06, 2016 8:22 AM
To: ejlb/google-open-image-download google-open-image-download@noreply.github.com
Cc: Scott Roth scott.roth@armedia.com; Mention mention@noreply.github.com
Subject: Re: [ejlb/google-open-image-download] UTF-8 charaters on Windows (#1)
Hi @msrothhttps://github.com/msroth thanks for the issue. I think this is due to csv dict reader. I'm going to push something now that should fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/1#issuecomment-251945788, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD3HHi3xOsUTt_ctB5VOAYfeioAYcIrRks5qxOgFgaJpZM4KOBmk.
@msroth could you try again when you get a chance. I can't reproduce the issue but I think this should fix it.
I just tried and get a new error. I posted it on GitHub. Something about dict has no iteritems attribute. What version python? I’m using 3.5.2. I’m also on Windows. I’ve seen a difference between Windows and Linux when it comes to UTF-8 chars.
Cheers,
Scott Roth
[Armedia_blue_small]
Test & Evaluation Lead
Science and Technology Integration Lab (STIL)
2070 Chain Bridge Dr., #100
Vienna, VA 22182
scott.roth@armedia.com
Cell: 703-408-1187
Office: 571-395-8875
From: Eddie Bell [mailto:notifications@github.com]
Sent: Thursday, October 06, 2016 8:53 AM
To: ejlb/google-open-image-download google-open-image-download@noreply.github.com
Cc: Scott Roth scott.roth@armedia.com; Mention mention@noreply.github.com
Subject: Re: [ejlb/google-open-image-download] UTF-8 charaters on Windows (#1)
@msrothhttps://github.com/msroth could you try again when you get a chance. I can't reproduce the issue but I think this should fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/1#issuecomment-251952446, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD3HHpbTkpVY472JOm8c76maoy5nrJwvks5qxO8ngaJpZM4KOBmk.