Release 1.7.8 having the same External ping duration bug as #2
otzy007 opened this issue · comments
Andrei G commented
Hi,
It looks like 1.7.8 release on rubygems has this bug with Ping::External where the time is incorrectly computed
Open3.popen3(*pcmd) do |stdin, stdout, stderr, thread|
stdin.close
@end_time = Time.now
It's the same bug found on #2 but fixed on master.
Wasn't this bug fixed on 1.7.8?
Also the changelog is stopped at 1.7.7 https://github.com/chernesk/net-ping/blob/master/CHANGES
Chris Chernesky commented
Thank you for the bug report. I'll check this out and get a fix out as soon as I can.
Andrei G commented
ok. Thank you 😀
Chris Chernesky commented
I believe this was fixed with v2.0.0. Please re-open if this is still an issue.
Andrei G commented
I can confirm that on v2 the response time is right. Thank you 😀
Chris Chernesky commented
Thanks @otzy007..