Typo in python selection sort

Question

Typo in python selection sort

whatisnormal opened this issue 6 years ago · comments

What is normal commented 6 years ago

Hi,
Current
if arr[i] < smallest: smallest_index = I

should be

if arr[i] < smallest: smallest_index = i smallest = arr[i]

Ramit Mittal · Answer 1 · Wed Apr 25 2018 13:27:19 GMT+0800 (China Standard Time)

@B3Y0ND3R I couldn't find capital I in 01_selection_sort.py

What is normal · Answer 2 · Wed Apr 25 2018 18:32:19 GMT+0800 (China Standard Time)

Hi @ramitmittal , the capital I was a typo sorry.
We should have the "bold" line also can you please confirm? Otherwise "smallest" will always be the initial value arr[0]

if arr[i] < smallest:
smallest_index = i
smallest = arr[i]

Ramit Mittal · Answer 3 · Thu Apr 26 2018 21:20:45 GMT+0800 (China Standard Time)

I verified the error.
smallest = arr[i]
needs to be added.
I have submitted a pull request after correcting.

Ramit Mittal · Answer 4 · Tue Oct 09 2018 14:17:30 GMT+0800 (China Standard Time)

solved in accepted pull request #72 , please close this issue