JS backend: Array.toList drops first element

[Marcial Gaißert]

Executing .toList on an array drops the first element.

Example

For the program:

import mutable/array

def main() = {
  val array = arrayFromList([1,2,3]);
  println(array.toList)
}

we get the output:

Cons(2, Cons(3, Nil()))

[Marcial Gaißert]

Problem seems to be the > in the array-to-list conversion here, should be >=:

effekt/libraries/js/mutable/array.effekt

Lines 52 to 60 in e68b8b3

 def toList[T](arr: Array[T]): List[T] = { 
   var i = arr.size - 1; 
   var l = Nil[T]() 
   while (i > 0) { 
     l = Cons(unsafeGet(arr, i), l) 
     i = i - 1 
   } 
   l 
 }