public_id is always set

Question

public_id is always set

cthulu opened this issue 5 years ago · comments

I think this is a problem if you want to be able to be to upload images with the same name and still have them uniquely named - using the unique_filename option. Because the public_id is always set, Cloudinary will use that and never generate the unique filename.

I've solved this locally by modifying the source code (commenting out index.js:72, but I believe this might affect more people. Would public_id need to be set anyway? The upload options should be able to solve all of this automagically, right?

Joris Berthelot · Answer 1 · Wed Jan 01 2020 18:44:51 GMT+0800 (China Standard Time)

Hi @cthulu,

Indeed, the public_id is always set because I originally developed this adapter to use it with my RetinaJS plugin, which requires using the same file name from the beginning.

I believe I could re-work this part to upload the first image, get its name and generate the retina variants from it but it would be a lot of back and forth with Cloudinary API.

However, I will try to make this option available because you might not be the first person who would like to enjoy this Cloudinary feature.

cthulu · Answer 2 · Thu Jan 02 2020 03:02:09 GMT+0800 (China Standard Time)

Yeah now I understand the reasoning for that. I would say, maybe it makes sense that if the use_unique is specifically set to true, don't set the public_id

…

On Wed, 1 Jan 2020, 11:44 Joris Berthelot, ***@***.***> wrote: Hi @cthulu <https://github.com/cthulu>, Indeed, the public_id is always set because I originally developed this adapter to use it with my RetinaJS plugin, which requires using the same file name from the beginning. I believe I could re-work this part to upload the first image, get its name and generate the retina variants from it but it would be a lot of back and forth with Cloudinary API. However, I will try to make this option available because you might not be the first person who would like to enjoy this Cloudinary feature. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#70?email_source=notifications&email_token=AAI7OEF3MGURP537XAEC4TTQ3RX2HA5CNFSM4KBUDR7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5COMQ#issuecomment-570042162>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI7OEEMMS6XV4KOLDO43MLQ3RX2HANCNFSM4KBUDR7A> .

cthulu · Answer 3 · Mon Jan 20 2020 18:38:06 GMT+0800 (China Standard Time)

Hey, any chance of including this in the next release?

Joris Berthelot · Answer 4 · Mon Jan 20 2020 21:28:08 GMT+0800 (China Standard Time)

@cthulu On it: #72

Joris Berthelot · Answer 5 · Wed Jan 29 2020 03:28:12 GMT+0800 (China Standard Time)

New release: https://github.com/eexit/ghost-storage-cloudinary/releases/tag/2.1.0