eelcocramer / node-gpsd

Node.js gpsd client for GPS tracking device.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Suggestion: Remove dependency on Winston

sajacy opened this issue · comments

This is a great module - but I don't want Winston logging. (run npm shrinkwrap to see why).

I'd suggest a simple change of accepting an options.logger parameter. Something like:

var noop = function() {};
this.logger = options.logger || { "info": noop, "error": console.error };

Corollary: setVerbose(...) would be removed from the library as well.

I can make the changes and provide a pull request if you'd prefer.

Thanks for the suggestion. I think it's an excellent improvement. If you want to make a pull request I would appreciate it.

Fixed by PR from issue #5