Solves in reverse order

Question

Solves in reverse order

MelvinSnijders opened this issue 2 years ago · comments

Melvin Snijders commented 2 years ago

Using Solver.SolveAll(); will result in a reverse order, and somehow a duplicate being printed, as seen below:

This is my folder structure:

It looks like this issue is related to #137, but I'm not sure why this happens in my case.

Eduardo Cáceres · Answer 1 · Mon Dec 12 2022 05:17:48 GMT+0800 (China Standard Time)

Hi Melvin,

Thanks for suing AoCHelper and raising the issue.

The reverse order problem has indeed to do with the other issue you pointed out. Based pure observation, types were returned ordered by FullName when invoking System.Reflection.Assembly.GetTypes(), but apparently that's not the case when one has _ symbols in them, and that's your case. I'll make sure to explicitly order them so that you get them in the right order.

Your repository also uncovered another issue: AoCHelper doesn't handle correctly exceptions in the constructors, with such exceptions making the Solve/SolveAll methods crash. I'll also look into that.

Regarding that duplicate being printed, I need to look deeper into that since it involves Spectre Console. It brings back some ghosts from v0.x when Spectre Console didn't support Live display.

Eduardo Cáceres · Answer 2 · Mon Dec 12 2022 07:31:36 GMT+0800 (China Standard Time)

@MelvinSnijders Could you please test v2.0.2-alpha.1 version and verify that both the ordering issue and the construction exceptions one are fixed?

I'll track the double rendering issue separately in #143.

Melvin Snijders · Answer 3 · Mon Dec 12 2022 16:31:41 GMT+0800 (China Standard Time)

Just tested it, works great, thanks!

Eduardo Cáceres · Answer 4 · Mon Dec 12 2022 18:38:26 GMT+0800 (China Standard Time)

Awesome to read!
I'll try to look into the other issue, but if I don't immediately solve it I'll just release a non alpha version for these ones (v2.0.2) in the following days.