eduardomoroni / react-clean-architecture

A realistic approach to implement clean architecture on react codebases

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Project is build with errors

ModPhoenix opened this issue · comments

Regards!
When I executing a command yarn start getting an error:

Failed to compile.

C:/Projects/react-clean-architecture/authentication/web/node_modules/core/dist/adapters/redux/saga.d.ts
(16,54): Cannot find module '../../../../../../../Projects/react-clean-architecture/authentication/core/node_modules/redux-saga/effects'.

And I needed to change the import path: "core": "file:../core" to "core": "../core"

System:

Windows 10
Node: 10.15.3
Yarn: 1.15.2

Thanks @ModPhoenix, I'll fix this here.
Just to confirm, were you able to manage it?
I tried here and it's working, I'm wondering if the repository is not explanatory about how to run on windows.

I tried but could not start the project.
Just wanted to let know that there is such a problem on Windows.

Thanks for letting me know.
Seems like the symlink proccess works different on windows environment.
image

I'll push a fix soon.

@ModPhoenix could you try once more?

The fix:

  • delete you authentication/node_modules
  • go to core/, then run npm install and npm run build
  • go back to authentication module, and now run npm install and npm start.

Explaining the problem:
The installation process relies on symlinking, the normal process would be:

  • Once you run npm install on the authentication module, npm hook will also install core module.
  • Once you run npm start on the authentication module, npm hook will build the core module and then start the app.

The problem is that this npm run build on the core module is not being reflected on authentication/node_modules/core because during the installation npm is not properly symlinking.

I really appreciate your issue. Thanks

Thanks @eduardomoroni, now everything works)