Update linting to conform to latest Sass Guidelines
jackmcpickle opened this issue · comments
@eduardoboucas have you thought about adding a linter to the test. Could help with issues around class formating and the like. I use sass-lint, but I think they are all the similar.
I'm in the process of integrating Travis, so this might be a good time to add linting. Are you able to help with that?
Well, actually we do have linting: https://github.com/eduardoboucas/include-media/blob/master/.scss-lint.yml (I'm clearly still half asleep). 😴
I should be able to just add this to the test suite and integrate with Trevis.
We should sync this linter up to the latest version (Sass Guidelines).
A thing to note about scss-lint: You need to have the gem installed, which (as far as I've seen it) is not described anywhere as a prerequisite.
A pure Node.js solution would be better, especially as even Sass itself is moving away from Ruby. Could we use this one instead?
SASS-lint isn't (yet) good enough to replace SCSS-lint. Too many options missing and too many bugs. Specially with indentation.
I've used sass-lint for the last year or so. Havent seen too many problems. Most of the issue I've had are with integration with the editors..
Either way - will put something together shortly.
When it comes to linting, stylelint is mature, works very well and is actively developed and maintained. However, it focuses on css syntax. There's a scss plugin that covers special scss syntax, but it's not as mature as stylelint.
In my experience (about 4 months production usage of stylelint), I'm very satisfied with the tool. I haven't even bothered yet to try out stylelint-scss because the additional coverage is not a big deal.
Closed via #158.