Fairer comparison with SqlAlchemy
jsimonlane opened this issue · comments
It looks like the SqlAlchemy uses their own native async engine.
engine = sa_asyncio.create_async_engine(
f"postgresql+asyncpg://sqlalch_bench:edgedbbenchmark@"
f"{ctx.db_host}:{ctx.pg_port}/sqlalch_bench"
)
If you subbed in your (ie MagicStack's) AsyncPG library instead instead (should be a couple line change), I'd be very curious to see a comparison... that would be a revealing benchmark to see how your EdgeDB Query Optimizer is doing (vs how much of the performance difference is better serialization).
Would this make sense as either an additional benchmark or even a replacement for the existing SqlAlchemy benchmark, @fantix? If either, I suspect maybe the former would be better since most people would probably use the SqlAlchemy native async engine.