edge / wallet

The web wallet of the XE Blockchain.

Home Page:https://wallet.xe.network

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Create a wallet screen single-step

adamkdean opened this issue · comments

Currently, the 'Create a wallet' screen has two steps:

image
image

This needs to be changed to be a single step.

It needs to show the wallet address and private key, then ask for a single password with the wording "ENTER PASSWORD TO ENCRYPT THIS SESSION", and at the bottom, it should say

"Please type 'I confirm I have backed up my private key'"

and require they type that phrase (though do a lowercase check on that for those who type i instead of I)

commented

Done as pictured below.

image

@annybs looks good but just two things to change if you could:

image

  1. Case insensitivity in the confirmation phrase
  2. Disable Next button until both validation criteria are fulfilled
commented

I didn't make the check case-insensitive because I understood this to affirm case sensitivity, like other such checks I encounter online (e.g. on GitHub)

(though do a lowercase check on that for those who type i instead of I)

I can make these changes next time I'm in the area, anyway.

commented

Disable Next button until both validation criteria are fulfilled

This is a bit tricky as written, because validation isn't actually invoked until the next button is clicked. As such, it would be impossible to enable the button.

The validation behaviour could be changed in future, but for the moment to get 1.9.1 out ASAP I've done a quick fix where the button is disabled until both fields contain some text. I'll have another look at it later when I work on security updates.