edge / mobile-wallet

Mobile wallet app for managing XE & Ethereum wallets

Home Page:https://ed.ge/app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Outstanding tasks

PJDavis1970 opened this issue · comments

To do for Launch

  • Internal E2E testing on Mainnet @adamkdean in progress

Cannot replicate

Post-launch

Done

  • Wallet already exists, continue button still visible, can proceed
  • Memo validation changes/fixes
  • Eth Mainnet Tx fee bug (shows wrong amount)
  • Settings > Support link change [https://wiki.edge.network/support/other-issues]
  • Settings > Remove dev section
  • Earn > XE Staking on Testnet shows Mainnet stats
  • Learn > XE Explorer on Testnet goes to xe.network (should be test.network)
  • Wallet (pan modal) not real-time updating
  • Swap dropdowns misbehaving (selecting wrong wallets)
  • Max button for sending XE is now working like ETH, taking a fee from the amount and not allowing the full amount to be used
  • Error message on transaction confirm screen needs a bit of padding below it so it isn't too close to the button
  • Pending XE transaction showing received a week ago, ETH symbols, and no data [see video in bugs]
  • Last transaction doesn't update when switching networks to an empty wallet (one wallet on network, no transactions)
  • Transaction showing value of 0.000000 XE when it is actually 0.900000 XE (for 1.4 XE it shows 1.000000 XE so decimals are being ignored—could this be related to the change in the Fee screen, where it shows "Swap must exceed XE"?) [see bugs]
  • On sending tx, "Transaction error:" label pops up
  • Hyphens are being stripped from memos
  • Eth transactions not factoring in transaction cost when determining maximum able to send
  • Memos overflowing
  • Re-authenticate after app runs in background - not working x-device
  • Swapping to testnet, receive screen has green background
  • Wallets added to both testnet/mainnet showing balances for wrong network still [via Vince822]
  • You can restore twice the same wallet (not sure it's really useful) [via Vince822]
  • If you try to restore the wallet by putting the wallet address and not the private key, the app crash (BTW if you have anything in the copy-paste and click on Paste button, you can click Continue) [via Vince822]
  • When swapping network and selecting a Wallet, shows previous (wrong) wallet from other network
  • Update Infura and Etherscan API Keys
  • Swap - change button label to from Create a Wallet to "Add Wallet"
  • Add Wallet screen - Change title from "Wallet Type" to "Choose Wallet Type" (styling is grey, bold, as per Learn)
  • Add Wallet screen - remove "...supporting ERC-20 tokens) to allow same font size as 'Stake and earn...'
  • Wallet detail - address should be monospace and XE logo is too big
  • Update padding on Memo (viewing tx)
  • Update tick icon on Transaction Detail screen (to match web)
  • Feedback needed on swap screen when amount entered is under whatever threshold disables the Review Swap button
  • Test App response to hitting API rate limit
  • Swap not working when using "Max" function (esp if Swap To i selected first)
  • Swap - display min amount as integer
  • Swap minimum error message: "Swap amount must exceed [N] XE" + message should also appear for USDC
  • Check testnet / mainnet caching
  • Add timer to wallet page tx list display
  • Add timer to tx info page display
  • Swap - user can select on “No Available Wallets” and see an empty overlay. Replace the empty field with a CTA button to link to "Create a Wallet" (Eth) then return user to the Swap screen with the newly created wallet pre-populated.
  • Gas/tx fee label should be on the Amount row, not To
  • XE transactions should show "Fee: 0 XE ($0.00)"
  • XE transactions hang on submitting [blockchain doesn't report any request]
  • In Wallet, under 'NETWORK' - "XE Mainnet" (not MainNet), it's correct in Settings
  • Last transaction address has wrong font
  • Wallet details address has wrong font
  • Other stuff - switch Earn & Signal position and link to correct content
  • Release for Open Beta testing AND run internal E2E testing on Testnet
  • Enable Mainnet switch (check for clean state, IE: app runs onboarding)
  • Downtrend value is green, should be grey
  • Ethereum Tx: Fee showing up as an input field "Leave a memo..."
  • XE Tx: Memo showing up as an input field "Leave a memo..."
  • XE Wallet: monospace font not used
  • Ethereum Wallet: monospace font not used
  • Wording for wallets needs to change — see: https://discord.com/channels/371989135172567051/893073292355846145/954029564689006592
  • Blue select arrow showing again , only on Send screen
  • Swap - remove touch / select state for “No Available Wallets” (so "Select Wallet" modal cannot load)
  • Formatting of Ethereum addresses sometimes uses × sometimes uses x (should just use ×). Change all address fields / entries to Menlo monospace (iOS default mono font)
  • Ethereum convention is exclusive fees, not inclusive. But we still need to show the gas cost: "Gas: xxxx gwei ($xxx)"
  • Add Gas Base+Tip to Index API @adamkdean
  • tx data is not saving locally (possible encoding issue)
  • Refactor transaction queries to index to reduce load
    • Poll wallets summary endpoint to check for changes to wallets (as well as to get last tx)
    • Update wallet transactions only when changes are detected
    • Get pending txs from index rather than the blockchain directly
    • Scroll down to load more txs (pagination exists in Index, ?page=X where the limit is 10 by default)
  • Send - Error message format. Padding / alignment and message to: ""Transaction failed: " where reason is received from the blockchain in the error response."
  • Improve error handling and display of error information (including Error handling for when transaction fails)
  • Invalid To address on send gives no feedback that there is a problem
  • Fee shows 0 — impossible for Eth txs. Show instead of Memo field
  • Refresh rates: Gas & exchange = 15 sec. Tokens = 60 secs
  • Use Gas: 0.00622212 Ether ($0.00) etc format for ethereum tx fees
  • Swap - remove redundant field and fix blue dropdown UI
  • On send ether change text in placeholder to match wallet
  • When you first select an Ether wallet to swap to it shows the currency as Ether, even though only XE and USDC are available
  • display 'the exchange maximum is (rates.limit) xe' when selected amount is above limit when swap to usdc.
  • sale transactions displaying as 0 edge not usdc
  • Justify text: "Your transaction will be submitted to the Ethereum blockchain. It may take a few minutes to process."
  • Swap process - values aren't constrained
  • On sending a transaction, immediately update last tx
  • remove duplicate tx when hash matches for ether and token tx's
  • EDGE->XE swap (an EDGE ERC-20 transaction) showing up as an empty eth transaction instead of an EDGE transaction
  • On pull to refresh Wallet, refresh last tx as well as markets
  • Value to reset after completing a swap (currently the amount remains)
  • Swap from wallet to be preset when tapping Swap button from a wallet card
  • After adding a new ethereum wallet, I have to close the app and restart to get it to show up in the Swap wallet list
  • Deposits: EDGE -> XE transaction does not appear to function (sometimes work, sometimes doesn't)
  • Disable 'Confirm' swap button when the referenced rate (gas rate for XE->EDGE, exchange rate for XE->USDC) is older than a minute
  • Deposits only: Fee is just the handling fee (minimum or 0.7% of amount, whichever is higher) NO GAS ADDED
  • Send - memo validation, add Regex [a-zA-Z0-9 -:]{1,64}
  • Transactions - Add memo to details screen
  • Disable Confirm Swap button when amount entered is greater than respective token balance
  • Refresh cycle for all swaps to be 15s not 30s (this matches web wallet)
  • On submitting EDGE -> XE, button greys out and displays "Submitting..." but then turns green again, remains saying "Submitting..."
  • Receive "Share" button not working
  • Amount/They will receive to match styles (Confirm Transaction) - currency symbol location
  • Settings page -> About should go to https://wiki.edge.network/getting-started/a-brief-history
  • Earn page -> Stargates/Gateways/Hosts to be removed, replaced with 'Coming Soon' as below with Eth Staking
  • When scanning Ethereum QR code, remove the ethereum: prefix if it exists
  • Pin screen - Change secondary text to "Enter your 6 digit code to unlock"
  • Add copy line (in grey) to Edge>XE swap summary (at 'Submitted...' button) "Your transaction will be submitted to the Ethereum blockchain. It may take a few minutes to process."
  • Supply copy line for Swap summary, EG: "Submitted to ETH network, which may take a few minutes" = "Your transaction will be submitted to the Ethereum blockchain. It may take a few minutes to process." @PJDavis1970
  • For non-XE transfers, show token (under address) in memo field
  • Transactions - Validate green colour for "Sent" & "Receive" text and arrows
  • Transactions - Singular "1 confirmations" in Transactions
  • Transactions - At 10, it should say "Confirmed" (not 'Sent' or 'Received') and should have tick in circle (to match web)
  • Swap - Select Token - second line should be grey
  • Swap - If select ETH in top field, default to Edge and dropdown arrow
  • Swap - seeing blue arrow for dropdown
  • Swap - with single wallet the second 'Swap To' field is empty - touching this crashed the app
  • Add toke suffixes to SWAP summary values
  • Add sell XE to USDC
  • Send transaction confirmation to show emoji overlay
  • Trim memo for trailing/leading whitespace
  • Pending txs (no confirmations) showing 0 value
  • Pending transaction, confirmations, sent/received for confirmed (as discussed)
  • View on explorer goes to index (it shouldn't)
  • View assets to match transaction font styles
  • Receive copy button to hide pan modal and then show message
  • XE Transactions to show memo under XE, date under value
  • Transactions need to differentiate between outgoing (red arrow up + address to)/incoming (green arrow down + address from)
  • Outgoing transactions to show minus value, -50.000000 etc
  • Exchange Screen fix showing correct exchange to wallets and hook in confirm screen
    Home page change exchange to be Pan modal and display to selection
  • Swap screen selecting an XE wallet should only show destination Ethereum wallets, and only show EDGE and USDC tokens
  • After sending tx, some sort of notification is needed 🎉
  • Exchange screen add additional data to bottom of review
  • Assets to hide percentage and up/down icon if 0
  • exchange token selection make Eth not Ether
  • token selection screen add token $name under main name and add value under token amount
  • markets add 2 decimals to edge $ value
  • Copy address to still show message as it hides the panmodal
  • Wallet screen exchange should say swap
  • Wallet page change no transaction font to non bold
  • Signal screen add Loading while first downloading data
  • After opening app and using pin instead of face, biometric check shows up again, and upon cancelling it, nothing happens. Shouldn't show up a second time.
  • Pending transactions should have < 100% opacity -- try a few options
  • Delete wallet needs confirmation
  • Delete wallet disabled for last XE wallet
  • Signal screen load first and show spinner
  • Signal screen pull to refresh
  • Swap screen selecting an Ethereum wallet should only show destination XE wallets and only show XE token
  • Swap screen shouldn't reset From value when changing destination token
  • Swap screen review 1 XE = 1 EDGE (no need for 1.000000 in the exchange rate)
  • Pending transactions should display "Pending" instead of "X mins ago"
  • Wallet screen "No Transactions" to be grey, not bold, and vertically centred
  • Network selection showing Mainnet selected
  • Transactions/Assets list (no pull-to-refresh) automatic refresh every 5 s
  • Account name overflowing the Edge value in Send screen
  • Account name should say "Address" in Send screen
  • Send review screen "Fee: 0 XE ($0.00)" should be grey not green
  • Send review screen "They will receive" should be in a box like amount/to/from
  • Earn screen Eth staking "Coming Soon" should be grey like TBC
  • Earn screen icons to be smaller
  • Create wallet screen padding on text with copy button
  • Backup wallet screen padding on text with copy button
  • Swap screen review quote to count from 30 to 1 not 30 to 0
  • Swap screen review space between sentence and counter
    image
  • Copy address on receive to close the pan modal
  • Wallet screen "No Transactions" hidden when viewing assets
  • Transaction Details should always be From -> To not To -> From
  • Transaction Details should be "View on Explorer"
  • Transaction Details show truncated wallet addresses rather than tiny text
  • Network selection left aligned message "Mainnet disabled during beta testing"
  • Settings - Manage - Remove button handle functionality
  • Markets - Percentage broken
  • XE coin get correct in progress data from https://api.xe.network/transactions/pending, https://xe1.test.network/transactions/pending
  • Wallet page transaction view add correct data, icons, received, sent, etc
  • fix face authentication
  • Markets - value needs commas (EG: ¢3,000)
  • Markets - Edge value seems wrong
  • Store data to local storage so I can populate data areas while waiting for initial data download (most done just last transaction to add. This needs a slight be of refactoring)
  • Exchange wallet cancel -> x
  • Exchange remove second label (Swap from/to)
  • Review Swap quote updates as discussed
  • Review Swap timer should go from 0:30 to 0:01 and not 0:29 to 0:00
  • Review Swap timer should use colon not period (0:29 not 0.29 etc)
  • Add exchange back to tabbar and build screen from designs Joseph is supplying
  • Add x2 map backgrounds to Swap screen (1 behind each pair of fields)
  • Confirm Transaction screen confirm with pin cut off on iPhone X
    Screen shot could help find issue
    Need endpoints to get this data
  • Wallet page transaction view remove down arrows and clean screen.
  • Rename "Exchange" to "Swap" in all instances
  • remove settings from tabbar
  • Signal default news image @adamkdean
  • Add auto scroll function on pan modal view (as required device / no user UI element)
  • Wallet Card display issue in Dark Mode
  • manage wallet reorder not saving position
  • Tab bar remove exchange and add settings to end
  • Earn screen remove heading and reduce spaces to match signal
  • Earn screen removing coming soon and replace with 1 coming soon text for eth staking
  • Earn screen remove decimals from coin amount
  • Home page last transaction space to icon larger than markets
  • Wallet Page assets tab replace dollar value with coin amount and add dollar value next to up/down percent
  • Manage Wallets to have + top right for adding wallets, return to manage wallets screen after completion
  • Settings cog too thin compared with other icons @adamkdean
  • Earn figures need hooking up
  • Tim initial bug
  • When you first install and/or there is no transaction history, the “Last transaction” section on the Home Screen should be hidden.
  • Select Network button showing Changing Networks popup even though disabled
  • hide last transaction on home page when no transactions in history

  • Gaps between different Pills/Boxes are all mismatched. Markets on wallet screen is great. Networks in network choice and wallets in manage wallets needs to be corrected. See below:

image

  • On Confirm Tx screen, the Fee text colour should match the (XE) colour, and also be right aligned
  • On Confirm Tx screen, the (XE) text should only have one regular space between itself and Amount

  • Truncation of Signal article item should append ... with a space, not just ...
    This is apple controlled. Can override however not sure whats involved.
    No problem
  • Assets screen to show assets like so. XE to show XE value in big text, Ethereum to show EDGE in big text.

  • Assets showing a faint grey border underneath (shouldn't be)
  • lighter green icon for XE coin icon @adamkdean
  • Burger Icon on the Manage Wallets screen is too dark
  • Learn Screen hook up buttons
    Need urls for buttons
  • Send To box not to resize text smaller
  • If wrong pin entered, alert pops up, if you retry and enter pin again, nothing (for either right or wrong)
  • Wallet Icon on tab bar needs replacing
  • Transactions - Found issues with token transaction downloading
  • Pending txs do not show up anywhere
  • No transactions in list show display message saying "No transactions yet" centred.
  • Learn Screen format hyperlink
  • Settings - Manage - Backup button handle functionality
  • Restore wallet > Text input paste button doesn't look good, should match the Send box for the address
  • Buttons inside input boxes don't match throughout the app: Send Max button dark grey, QR + Paste Light grey, Create wallet copy button is very dark grey and no padding, Restore paste button is tiny and dark grey
  • Wallet Page exchange button hook up to exchange main screen
  • Transactions - Home Screen last transaction create function in Wallet model manager to find latest date
  • Transactions - Wallet Page - fix time stamp on XE transactions. Showing 0 Sec ago
  • Transactions - Wallet Page - populate transaction popup
  • Transactions - Wallet Page - sort order of transactions by date
  • Signal item better date format (Fri, 14 Jan 2022 18:30) lose the seconds and timezone
  • Markets % value
  • Network selection message truncation
  • Manage Wallets drag to rearrange order
  • Last transaction is not hooked up
  • Transaction Memo is "Testing" regardless of what you input
  • Add wallet > Icons shouldn't have grey circle and black background
  • QR code box not vertically centred
  • Download coin values from edge endpoint for Market graphs
  • Using above issue, display icon for up or down icon on assets cell
  • Swap Assets/Transactions to Transactions/Assets with transactions being default
  • Manage Wallets > Wallet Details "Last Backedup" to say "Last Backup"
  • Learn icon quality not adequate, icons need to be white, not green in the case of edge/xe
  • Manage Wallets > Wallet Details Buttons/text too big also
  • Restore wallet > Text box says "Wallet Address" (should be "Private Key"
  • Confirm Transaction screen "They will receive" text too large, doesn't match other input labels
  • Margin at top of Learn screen is too great, needs to match other screens
  • Manage Wallets title should not be "Manage accounts"
  • Signal add web image handling to smooth scrolling
  • Learn screen build
  • Home Screen portfolio value. Refactor tot values in Wallet model manager to allow easier calculations for all areas.
  • Home Screen display total wallet value
  • Home Screen markets display graph. Using Library from git.
  • Wallet Page transactions remove total transaction value from cell
  • Signal screen build
  • Full address strings to be evenly distributed over 2 lines
  • Settings - Network page match to rest of design
  • Change colour of QR code camera icon from black to white
  • Edit spacing on settings screen to match settings button, etc links on home page
  • remove settings from tab bar. Link settings from home page instead or tab hookup
  • Gap between "Other stuff" and first link needs reducing
  • Polish tabbar icons
  • Earn copy editable
  • XE testnet cap T / Rinkeby testnet
  • Main card address and address bigger vertical space wallet address font same size as address font
  • Exchange button on Home Screen make other icons smaller
  • Last transaction cell close text
  • Markets closer together
  • Menu item separators darken
  • Home page bottom test editable. More space above it. Remove bounding boxes
  • Home page button reduce text
  • Receive page title and card gap bigger than buttons and card
  • All titles down 3 pixels
  • Text boxes 16 pixel left/right rather than 8
  • Send qr code screen remove circle from x
  • Square in qr move to centre
  • App icon change
  • Exchange icon circle remove
  • Account name address
  • Manage wallet special icon
  • Settings manage wallets overhaul
  • Earn headers smaller
  • Earn divider lines
  • Fix padding around widgets and data cells
  • Make all values display 2 decimal places
  • Fix onboarding flow to for xe only creation and not allow exit create screen
  • Tab bar height adjust pixel size above icons
  • Send screen needs QR code to scan address
  • Send screen header title needs to reflect coin being sent. eg "Send XE"
  • Modify Asset cell on wallet page
  • Hook in Transactions data to Transaction list on wallet page
  • Replace all token icons with new stencil image
  • Remove Buy from Wallet page

For me:

  • Create four SVGs: edge, xe, ethereum, usd icons

Closing this ticket now.