eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

fparse vs fload in readme

DavZim opened this issue · comments

Running the example from the readme, I get the error The JSON document has an improper structure: missing or superfluous commas, braces, missing keys, etc.

I receive the error both with the CRAN and the github version.

Do you mabye mean to reference fload in the readme and not fparse?

jsonfile <- system.file("jsonexamples", "twitter.json", package="RcppSimdJson")
library(RcppSimdJson)
validateJSON(jsonfile)                  # validate a JSON file
#> [1] TRUE
res <- fparse(jsonfile)                    # parse a JSON file
#> Error in .deserialize_json(json = json, json_pointer = query, empty_array = empty_array, : The JSON document has an improper structure: missing or superfluous commas, braces, missing keys, etc.

sessioninfo::package_info("RcppSimdJson")
#>  package      * version date       lib
#>  Rcpp           1.0.5   2020-07-06 [1]
#>  RcppSimdJson * 0.1.0.2 2020-08-05 [1]
#>  source                                    
#>  CRAN (R 3.6.3)                            
#>  Github (eddelbuettel/rcppsimdjson@6e4a27c)
#> 
#> [1] /home/CO-IN.LOCAL/dzimmermann/R/x86_64-pc-linux-gnu-library/3.6
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library

Yup, very embarassing thinko / cut&paste-o. Fixed now, first by accidents on a branch I was one and now in master.

Thanks for spotting this! (And @knapply please rebase)