utils::download.file()

[knapply]

@eddelbuettel There are packages on CRAN with an identical NOTE. Do you have a policy/preference here?

Travis Log

* checking R code for possible problems ... NOTE
fload: no visible global function definition for ‘download.file’
Undefined global functions or variables:
  download.file
Consider adding
  importFrom("utils", "download.file")
to your NAMESPACE file.

Code affected:

rcppsimdjson/R/fload.R

Lines 182 to 183 in 60e3d3f

 "ftp://" = download.file(diagnosis$input[[i]], destfile = temp_file, method = getOption("download.file.method", default = "auto"), quiet = !verbose), 
 "file://" = download.file(diagnosis$input[[i]], destfile = temp_file, method = "internal", quiet = !verbose), 

[Dirk Eddelbuettel]

As we use it, and R CMD check even suggests it we should of course add importFrom("utils", "download.file") to NAMESPACE. Or am I missing some meta conversation here? Also, why would we care what errors other packages make? ;-)

[Dirk Eddelbuettel]

I appreciate you asked. But on the margin. that is the type of one-line change you could just have committed. Or, better still, in a joint repo, put the one line change in PR, I look and nod and you merge and move on.

Some things really are that simple :)