econia-labs / econia

Hyper-parallelized on-chain order book for the Aptos blockchain

Home Page:https://econia.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue order ID for all orders, not just maker orders

alnoki opened this issue · comments

commented

Presently, Econia only assigns an order ID to the portion of a limit order that posts as a maker order.

This order ID is unique within a market, but not across markets (to ensure parallelism).

It is suggested that a parallelizeable globally unique ID be assigned to each order regardless of how much it makes or takes.

I don't think the ID needs to be unique across markets? We just need an ID that is assigned to all orders regardless of whether they are maker or taker orders. I don't think using the same ID in different market poses an issue

commented

I don't think the ID needs to be unique across markets? We just need an ID that is assigned to all orders regardless of whether they are maker or taker orders. I don't think using the same ID in different market poses an issue

Good point, and per @qdrs sequentiality within a given market could also help with iteration

commented

Marking as closed per v4.1.0 revisions