Test fail on latest
cdietrich opened this issue · comments
Christian Dietrich commented
ProgressReportingTest.testProgressReportOfRenameCommonDir
expected:<BeginTask (44)
[SetTaskName Checking preconditions...
InternalWorked 4.0 (4.0)
SetTaskName Checking preconditions...
InternalWorked 22.22222222222222 (26.22222222222222)
SetTaskName Preparing the refactoring...
InternalWorked 1.777777777777778 (28.0)
SetTaskName Preparing and applying file changes...
InternalWorked 0.8355555555555556 (28.835555555555555)
InternalWorked 0.8355555555555556 (29.67111111111111)
InternalWorked 0.4177777777777778 (30.08888888888889)
InternalWorked 0.4177777777777778 (30.506666666666668)
InternalWorked 0.4177777777777778 (30.924444444444447)
InternalWorked 0.4177777777777778 (31.342222222222226)
SetTaskName Creating text changes...
InternalWorked 2.088888888888889 (33.431111111111115)
InternalWorked 0.8444444444444444 (34.275555555555556)
InternalWorked 0.8355555555555556 (35.111111111111114)
InternalWorked 2.2222222222222223 (37.333333333333336)
InternalWorked 6.666666666666664 (]44.0)
Done> but was:<BeginTask (44)
[InternalWorked 4.0 (4.0)
InternalWorked 22.2 (26.2)
InternalWorked 1.76 (27.96)
SetTaskName Preparing and applying file changes...
InternalWorked 0.8 (28.76)
InternalWorked 0.84 (29.6)
InternalWorked 0.4 (30.0)
InternalWorked 0.44 (30.44)
InternalWorked 0.4 (30.84)
InternalWorked 0.44 (31.28)
SetTaskName Creating text changes...
InternalWorked 2.08 (33.36)
InternalWorked 0.88 (34.24)
InternalWorked 0.84 (35.080000000000005)
InternalWorked 8.920000000000002 (44.00000000000001)
Done
BeginTask Creating workspace modifications... (1000)
Worked 333 (377.0)
Worked 333 (710.0)
Worked 334 (1044.0)
Done
BeginTask Performing changes... (1000)
Worked 41 (1085.0)
Worked 1 (1086.0)
Worked 21 (1107.0)
Worked 20 (1127.0)
Worked 21 (1148.0)
Worked 20 (1168.0)
Worked 126 (1294.0)
Worked 41 (1335.0)
Worked 1 (1336.0)
Worked 21 (1357.0)
Worked 20 (1377.0)
Worked 21 (1398.0)
Worked 20 (1418.0)
Worked 126 (1544.0)
Worked 5 (1549.0)
Worked 125 (1674.0)
Worked 25 (1699.0)
Worked 75 (1774.0)
Worked 25 (1799.0)
Worked 120 (1919.0)
Worked 120 (2039.0)
Worked 5 (20]44.0)
Done>
@iloveeclipse was there some renaming in plaform or jdt?
Andrey Loskutov commented
Renaming of what?
Christian Dietrich commented
a dsl file.
Christian Dietrich commented
looks like the Checking Preconditions and Preparing the refactoring messages are gone
Andrey Loskutov commented
I assume that was something internal?
Christian Dietrich commented
i dont know
https://github.com/eclipse-platform/eclipse.platform.ui/pull/1266/files
was there a replacement for this
Lorenzo Bettini commented
@cdietrich this morning we got hit by this again
Lorenzo Bettini commented
Intead of
BeginTask (44)
InternalWorked 4.0 (4.0)
InternalWorked 22.2 (26.2)
InternalWorked 1.76 (27.96)
SetTaskName Preparing and applying file changes...
InternalWorked 0.8 (28.76)
InternalWorked 0.84 (29.6)
InternalWorked 0.4 (30.0)
InternalWorked 0.44 (30.44)
InternalWorked 0.4 (30.84)
InternalWorked 0.44 (31.28)
SetTaskName Creating text changes...
InternalWorked 2.08 (33.36)
InternalWorked 0.88 (34.24)
InternalWorked 0.84 (35.080000000000005)
InternalWorked 8.920000000000002 (44.00000000000001)
Done
we have
BeginTask (1000)
Worked 90 (90.0)
Worked 505 (595.0)
Worked 40 (635.0)
SetTaskName Preparing and applying file changes...
Worked 19 (654.0)
Worked 19 (673.0)
Worked 9 (682.0)
Worked 10 (692.0)
Worked 9 (701.0)
Worked 10 (711.0)
SetTaskName Creating text changes...
Worked 47 (758.0)
Worked 20 (778.0)
Worked 19 (797.0)
Worked 203 (1000.0)
BeginTask Creating workspace modifications... (1000)
Worked 333 (1333.0)
Worked 333 (1666.0)
Worked 334 (2000.0)
Done
BeginTask Performing changes... (1000)
Worked 41 (2041.0)
Worked 42 (2083.0)
Worked 20 (2103.0)
Worked 21 (2124.0)
Worked 21 (2145.0)
Worked 21 (2166.0)
Worked 84 (2250.0)
Worked 41 (2291.0)
Worked 42 (2333.0)
Worked 20 (2353.0)
Worked 21 (2374.0)
Worked 21 (2395.0)
Worked 21 (2416.0)
Worked 84 (2500.0)
Worked 5 (2505.0)
Worked 125 (2630.0)
Worked 25 (2655.0)
Worked 75 (2730.0)
Worked 25 (2755.0)
Worked 120 (2875.0)
Worked 120 (2995.0)
Worked 5 (3000.0)
Done
Lorenzo Bettini commented
With org.eclipse.ltk.core.refactoring_3.14.300.v20240109-1018.jar