MQTTClient.h: enum returnCode uses ubiquitous names prone for collisions

[ottingerg]

In our setup we are using the ST Hardware abstraction layer on an STM32F4 MCU.

We experience a collision of the enum name "SUCCESS" which is defined in MQTTClient.h:

paho.mqtt.embedded-c/MQTTClient-C/src/MQTTClient.h

Line 57 in 29ab2aa

 enum returnCode { BUFFER_OVERFLOW = -2, FAILURE = -1, SUCCESS = 0 }; 

and also in stm32f4xx.h
typedef enum { ERROR = 0U, SUCCESS = !ERROR } ErrorStatus;

Using Prefixes (on both sides) for the enum would be our preferred way to resolve this issue.
Unfortunatly on the ST HAL side 'SUCCESS' is referred 1000+ times.

For example:
enum returnCode { MQTTCLIENT_BUFFER_OVERFLOW = -2,MQTTCLIENT_FAILURE = -1, MQTTCLIENT_SUCCESS = 0 };

[Cristian Pop]

Duplicate #180

[Ian Craggs]

Closing as duplicate. But yes we should do it.