SubOptions (NoLocal,RetainAsPublished) always get false.

Question

BANice opened this issue 8 months ago · comments

Describe the bug

// it expect equal 0x04 not 0x01	
 s.NoLocal = (b & 1 << 2) == 1

To reproduce
make a client and sub topic with (NoLocal,RetainAsPublished) =true. Unpack function will always get false.

Debug output
Any debugging output provided by the client code while reproducing the bug (either embedded to link to the output)

Expected behaviour

BANice · Answer 1 · Wed Sep 27 2023 07:56:03 GMT+0800 (China Standard Time)

I will PR it late.

Matt Brittan · Answer 2 · Wed Sep 27 2023 08:38:32 GMT+0800 (China Standard Time)

I've found and fixed a few variations of this in the large change I'm working on. For reference the approach I've used is b&(1<<2) != 0.

BANice · Answer 3 · Wed Sep 27 2023 20:47:01 GMT+0800 (China Standard Time)

great. Thanks.

Matt Brittan · Answer 4 · Thu Sep 28 2023 03:40:38 GMT+0800 (China Standard Time)

Had not fixed this specific issue yet (that was the approach Ive used for other flags). Reopened this to ensure it's not forgotten.