eclipse-lsp4j / lsp4j

A Java implementation of the language server protocol intended to be consumed by tools and language servers implemented in Java.

Home Page:https://eclipse.org/lsp4j

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade to recent BND

laeubi opened this issue · comments

A recent discussion in OSGi-WG channels has shown that lsp4j uses bnd plugin in a "deprecated way", as I'm not familar enough with gradle I can only copy some instructions here that might be usefull for the maintainers of this project to upgrade given by @bjhargrave:

They are also using the bnd plugin in the old deprecated way. It should be jar.bundle.bnd and not jar.bnd. That is, the bnd DSL element has moved under the bundle DSL element. See https://github.com/bndtools/bnd/wiki/Changes-in-6.0.0#bnd-gradle-plugins for the bullet about gradle deprecation of conventions.

from that page you linked i cannot derive anything.
=> stupidly replace jar.bnd with jar.bundle.bnd and binary compare resulting jars?

can you also point to said discussion?

we also use more stuff that is deprecated in newer gradle versions

is anyone using the gradle ide task? does anyone know how to use it?

new bnd needs j17 to run build

is anyone using the gradle ide task? does anyone know how to use it?

Does this refer to the contents of https://github.com/eclipse-lsp4j/lsp4j/tree/db27a95ff71f6892074df6c404560c05f55552bc/ide ? If so, I don't think anyone is using them, if they are the references in them are really out of date. The underlying gradle plug-in is also "mostly abandoned" (diffplug/goomph#189) so I think we can remove it without further thought.

image

is anyone using the gradle ide task? does anyone know how to use it?

Does this refer to the contents of https://github.com/eclipse-lsp4j/lsp4j/tree/db27a95ff71f6892074df6c404560c05f55552bc/ide ? [...]

Removed in #794

#781 modernizes gradle usage (thanks @cdietrich for doing the heavy lifting)

new bnd needs j17 to run build

Because of this we are not at this time upgrading to bnd 7