There's no need to package `*.java` files into the runtime jar
raylras opened this issue · comments
raylras commented
- Including
*.java
files in the runtime jar makes it larger, but they are unnecessary during runtime. - It causes confusion when browsing the LSP4J source code in IDEA, as it results in duplicate classes.
Solution:
- Simply remove the contents of
org.eclipse.lsp4j/build.gradle
lines 27-29:
@@ -24,10 +24,6 @@
testImplementation "com.tngtech.archunit:archunit:$versions.archunit"
}
-jar {
- from sourceSets.main.allJava
-}
-
jar.bnd (
'Import-Package': "com.google.gson.*;version=\"$versions.gson\",*"
)
Jonah Graham commented
Great idea. Can you provide a PR please? We need to also check that the various sources jars still have all the sources after making the change.
Jonah Graham commented
Fixed by #764