Issue with XML package in Github r-lib v2 actions
maelle opened this issue · comments
Related to #59
Just for info we're seeing such compilation errors on Ubuntu with XML: EMODnet/EMODnetWFS/runs/6176000380?check_suite_focus=true
it's not really related to #59 by the way :-)
ows4R is not yet tested on ubuntu-latest. XML package is maintained by CRAN team, if there is some issue related to code compilation it will be probably fixed soon.
@maelle i've configured the github CI with ubuntu-latest for both R release/devel, and it works. Not sure why you got a compilation issue, maybe it's unexpected error, and trying to re-run the job will work.
Thanks, will do!
Ok, fyi i dont configure macOS and Windows CI tests because I do need to run docker images and docker doesn't work there, I will look further how I can build a more complete CI action later that would test over these OS.
@eblondel do you know of examples of GHA workflow without Docker that'd work for XML? Our standard workflows still don't work (which worries me for standard users that will try to install the package outside of Docker too). See https://github.com/EMODnet/EMODnetWFS/actions/runs/2257266720
Thank you 🙏
@maelle just a clarification, I'm not containerizing the tests within docker, but Docker is used to launch some applications WITHIN the VM that is launched with ubuntu for tests. Most of the packages i authored used XML behind, such as geometa, geosapi, atom4R. I'm going to add more configs to them to test them deeply, and to have a look to your config above to see what you could do.
Thank you!
For the record, I use Ubuntu locally, and was able to install XML without any particular issue.
@maelle looking at your action config, I see that you use v2 actions from r-lib, while in ows4R I used 'v1' for r-setup and r-setup-dependencies; and 'check-r-package' for check-r-package action https://github.com/eblondel/ows4R/blob/master/.github/workflows/r-cmd-check.yml#L46
This may be related in particular to https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies#installing-the-latest-dependencies I'm going to give a try over v2 r-lib/actions with ows4R and let you know
reverting at 6eac341
@maelle this is what I could investigate related to Github CI failures in building XML package:
- first, i've tried to switch from v1 to v2 actions, and this is how I could reproduce the issue of Github action r-lib/actions/setup-r-dependencies@v2 same as you are facing in https://github.com/EMODnet/EMODnetWFS
- As pointed out the issue relates to this https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies#installing-the-latest-dependencies, and the fact that in your build a cached version of the XML package is taken (3.99-0.3) instead of the latest XML version (see https://github.com/EMODnet/EMODnetWFS/runs/6347468114?check_suite_focus=true#step:5:5586)
- To fix the issue, I've enabled v2 action again, but paying attention to add 'XML' package as extra-packages (see https://github.com/eblondel/ows4R/blob/master/.github/workflows/r-cmd-check.yml#L54) to make sure to download the latest version from CRAN. With this the build goes well on ubuntu-latest for both R release and devel
Let me know if this fixes your build for https://github.com/EMODnet/EMODnetWFS
Success https://github.com/EMODnet/EMODnetWFS/runs/6521287978?check_suite_focus=true 🎉
Thank you!!
Wonderful!