Giters

ebiggers / libdeflate

Heavily optimized library for DEFLATE/zlib/gzip compression and decompression

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

LIBDEFLATEEXPORT+LIBDEFLATEAPI are redundunt and shouldn't be part of public libdeflate.h header

pps83 opened this issue · comments

commented

Here's how it should be imo
3b23880

libdeflate/libdeflate.h

Line 25 in 6519a16

#undef LIBDEFLATEEXPORT

Also, unrelated, but you cannot include headers inside extern c block. This will lead to errors in msvc if these headers weren't included before including libdeflate.h in some c++ code.

commented

Here's how it should be imo

#269 will do this. I made some changes from your version:

  • Retain support for LIBDEFLATE_DLL in libdeflate.h
  • Keep using force_align_arg_pointer in all the cases where it was used before
  • Add a better explanation to the commit message
  • Split the #include changes into a different commit and pull request
  • Edit: also removed LIBDEFLATEAPI from programs/test_trailing_bytes.c

you cannot include headers inside extern c block.

Done by #268