-Wundef warnings on Windows

Question

-Wundef warnings on Windows

lazka opened this issue 6 years ago · comments

Building gtk4 on Windows which uses -Wundef results in lots of warnings (see https://gitlab.gnome.org/creiter/gtk/-/jobs/21892):

C:/msys64/mingw32/lib/graphene-1.0/include/graphene-config.h:15:27: warning: "_M_IX86_FP" is not defined, evaluates to 0 [-Wundef]
 # if defined(__SSE__) || (_M_IX86_FP > 0) || (_M_X64 > 0) || (_MSC_VER >= 1800)
                           ^~~~~~~~~~
C:/msys64/mingw32/lib/graphene-1.0/include/graphene-config.h:15:47: warning: "_M_X64" is not defined, evaluates to 0 [-Wundef]
 # if defined(__SSE__) || (_M_IX86_FP > 0) || (_M_X64 > 0) || (_MSC_VER >= 1800)
                                               ^~~~~~
C:/msys64/mingw32/lib/graphene-1.0/include/graphene-config.h:15:63: warning: "_MSC_VER" is not defined, evaluates to 0 [-Wundef]
 # if defined(__SSE__) || (_M_IX86_FP > 0) || (_M_X64 > 0) || (_MSC_VER >= 1800)
                                                               ^~~~~~~~

Emmanuele Bassi · Answer 1 · Mon Apr 09 2018 17:21:09 GMT+0800 (China Standard Time)

It would be nice to have a MSVC compiler flag to catch the equivalent of -Wundef as well.

Christoph Reiter · Answer 2 · Tue Apr 10 2018 02:02:00 GMT+0800 (China Standard Time)

I could add a MSYS2 job to appveyor if you want.

Emmanuele Bassi · Answer 3 · Tue Apr 10 2018 02:54:00 GMT+0800 (China Standard Time)

@lazka The MSYS2 job would be appreciated as well. Did PR #115 work?

Christoph Reiter · Answer 4 · Tue Apr 10 2018 03:05:17 GMT+0800 (China Standard Time)

@lazka The MSYS2 job would be appreciated as well

ok, added to my list

Did PR #115 work?

Yes, build output: https://bpaste.net/show/5108f78c1a5e

Emmanuele Bassi · Answer 5 · Tue Apr 10 2018 03:17:28 GMT+0800 (China Standard Time)

Thanks!

I see other issues in that build log; would you mind filing them as well?