[Bug/Feature Request] Dark mode support

Question

[Bug/Feature Request] Dark mode support

916253 opened this issue 5 years ago · comments

Dark mode on macOS Mojave causes the text to change colors, but the background color remains the same, resulting in clashing colors which causes the text to become unreadable:

Evgeny Aleksandrov · Answer 1 · Wed Mar 06 2019 17:01:39 GMT+0800 (China Standard Time)

Strange, dark mode looks fine for me:

(+ #27 (comment))

macOS 10.14.3

Emma · Answer 2 · Wed Mar 06 2019 18:03:28 GMT+0800 (China Standard Time)

Interesting-- I tried this on multiple machines, one on 10.14.3, and another on 10.14.4 Beta (18E194d)
both exhibited the same results.
Would it be possible for you to force the plugin to always use light mode (via bool NSRequiresAquaSystemAppearance or similar)?

(In the meantime, I got lazy and just settled on setting the background color on my local copy to a color that doesn't conflict with the text in either mode, lol)

Evgeny Aleksandrov · Answer 3 · Wed Mar 06 2019 21:16:36 GMT+0800 (China Standard Time)

I don't remember doing any special settings, but I'll check on other macs anyway.

Thanks for sharing your solution :)

Evgeny Aleksandrov · Answer 4 · Mon Apr 22 2019 01:01:15 GMT+0800 (China Standard Time)

Full dark mode support added in #29 and released in 1.6.0 on Homebrew Cask.

Let's see if it fixes all your cases :)

Emma · Answer 5 · Wed May 01 2019 18:03:11 GMT+0800 (China Standard Time)

Hey-- sorry for the super late response
Yeah, that seems to have fixed everything, awesome!