ealeksandrov / ProvisionQL

Quick Look plugin for mobile apps and provisioning profiles

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add warning about Xcode plugin to Homebrew install flow

abotkin-cpi opened this issue · comments

Using macOS 10.14 (18A389) with dark mode with the latest version of ProvisionQL (1.5.0), the preview displayed is hard to read due to the main text being shifted to a very light grey that blends in with the blur of the Quick Look window. This only occurs when in dark mode & colors are a readable black when in light mode.

provisionqldarkmode

Thanks for report.
But - you're looking not at ProvisionQL, it's bundled Xcode plugin. Please check #20

In my test ProvisionQL works fine in dark mode:
image

Any chance the instructions/warning in #20 could be incorporated into the install script via Homebrew similar to how other tools in Homebrew give warnings about path additions needed for best functionality? When installing via Homebrew today, there is no information provided to the user that addition setup requirements may be necessary if they want it to work for provisioning profiles.

allegseu:ios abotkin$ brew cask install provisionql
==> Satisfying dependencies
==> Downloading https://github.com/ealeksandrov/ProvisionQL/releases/download/1.5.0/ProvisionQL.zip
Already downloaded: /Users/abotkin/Library/Caches/Homebrew/downloads/a06bb9a4cde5f73090266d943db25b07053a8a2f3a17d75e746574be905624fe--ProvisionQL.zip
==> Verifying SHA-256 checksum for Cask 'provisionql'.
==> Installing Cask provisionql
==> Moving QuickLook Plugin 'ProvisionQL.qlgenerator' to '/Users/abotkin/Library/QuickLook/ProvisionQL.qlgenerator'.
🍺  provisionql was successfully installed!

Good idea, thanks for suggestion! I'll see what I can do to add instructions on Homebrew.

Added caveat in 1.6.0 on Homebrew Cask:

> ~/Documents/dev/ProvisionQL brew cask install provisionql
==> Caveats
To prevent mobileprovision QuickLook override by Xcode: https://github.com/ealeksandrov/ProvisionQL/issues/20

==> Satisfying dependencies
==> Downloading https://github.com/ealeksandrov/ProvisionQL/releases/download/1.6.0/ProvisionQL.zip
Already downloaded: /Users/ealeksandrov/Library/Caches/Homebrew/downloads/b33882767370c967ffc70a8d9435fad930ca4db3d3f3775f9f31cc2512715051--ProvisionQL.zip
==> Verifying SHA-256 checksum for Cask 'provisionql'.
==> Installing Cask provisionql
==> Moving QuickLook Plugin 'ProvisionQL.qlgenerator' to '/Users/ealeksandrov/Library/QuickLook/ProvisionQL.qlgenerator'.
🍺  provisionql was successfully installed!