eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

Home Page:https://ebay.github.io/skin/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

fake-menu: number badge not supported

darkwebdev opened this issue · comments

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Not sure if it's a bug or intended behaviour, but:
when I use number badges in fake-menu they lack margins (like in a normal menu):
image

image

Expected behavior

image

Skin version

16

Device/OS/Browser info

firefox mac

Relevant code block

The problem is here:

.menu__item .badge {

.menu__item > svg.icon--tick-16:last-child,
.fake-menu__item > svg.icon--tick-16:last-child,
.menu__item .badge {
    margin-left: var(--spacing-100);
    margin-right: var(--spacing-100);
}

we just need to add another selector to this rule:

.fake-menu__item .badge

Additional context

No response