dyrkin / zigbee-steward

ZigBee hub

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Serial library's old version doesn't handle interrupted system calls

joonas-fi opened this issue · comments

Problem

Get interrupted system call errors from ZNP ReadFrame() failing.

Serial library is at an old version:

go.bug.st/serial.v1 v0.0.0-20180827123349-5f7892a7bb45

This old version seems to bypass Go's regular OS I/O interfaces (that would take EINTR into account), and doesn't take EINTR into account at all.

Fix

Update to new version, it correctly retries on EINTR.

Hi @joonas-fi,
Unfortunately, I have no time to support it for now. Do you want me to add you to contributors and you'll fix it by yourself?
Or of course, you can fork the project and fix it on your side.

No worries, and thank you for your projects! I mainly posted these issues to help users of this project :)

I've actually already forked most of these projects and done some major work on them, I will credit you and it will be open sourced as part of my home automation hub project https://github.com/function61/hautomo