Contributions and Licence?

Question

Contributions and Licence?

pwood opened this issue 5 years ago · comments

Hello Dyrkin!

After doing some initial looking into zigbee2mqtt, I found your suite of Go libraries for powering the CC2531 USB dongle and it works much better than the z2m in a lot of scenarios (especially pairing devices).

I've done some work on zcl-go (adding more clusters) and I've started on some changes to zigbee-steward (non singleton database, more functions for clusters, etc).

It'd be great to get these back to you so others might be able to benefit from them, and I can stop maintaining nasty replace directives in my go.mod files ;).

If I raised a PR would you consider merging them in? And while I'm not hugely fussed about which open source license, it'd be good to have one attached to the projects to make it clear about the state of contributions, etc. For unp-go, znp-go, zcl-go and zigbee-steward.

I also appreciate that you've not commited to these for 8 months or so, I guess you may not be using them? Would you appreciate a helping hand in maintaining them?

FWIW, my interest is in improving my own home Zigbee ecosystem, dumping the Phillips Hue bridge and interfacing a lot of the lower cost sensors from the Chinese vendors along side the nicer Hue/Tradfri bulbs.

Cheers,

Peter.

Yevhen Zadyra commented 5 years ago

Done

joonas.fi · Answer 1 · Sun Jan 19 2020 20:50:40 GMT+0800 (China Standard Time)

+1

Architecturally your projects seem cleaner than zigbee2mqtt (+ it's not JavaScript), and I would very much like to stop interfacing with MQTT and embed Zigbee directly into my home automation: https://github.com/function61/hautomo

I would also like to help, if help is needed.

Yevhen Zadyra · Answer 2 · Wed Jan 22 2020 03:34:32 GMT+0800 (China Standard Time)

Hi guys!
I've added the license file. Currently, I don't have time to contribute to the project, but I can help if needed.
Feel free to use it on your own.

bitver · Answer 3 · Wed Jan 22 2020 09:25:01 GMT+0800 (China Standard Time)

Could you do the same for unp-go, znp-go and zcl-go?

Peter Wood · Answer 4 · Fri Jan 24 2020 17:13:37 GMT+0800 (China Standard Time)

This is great to hear! Unfortunately for me I've gone another direction myself and started a similar project.

However if anyone wants to merge in the work I've done on @dyrkin's ZCL library or refactoring the datastore in the steward, please take this as my confirmation I'm happy for them to be transferred into the existing project under the MIT license.

https://github.com/pwood/zcl-go
https://github.com/pwood/zigbee-steward